Support alpha channel in as-hex
#203
Conversation
src/garden/color.cljc
Outdated
| (-> (util/format "%2s" (util/int->string v 16)) | ||
| (string/replace " " "0")))] | ||
| (str (apply str "#" (map hex-part [r g b]) ) | ||
| (hex-part (int (* 256 a)))))) |
There was a problem hiding this comment.
I'm no expert, but this looks like it might return the wrong thing when a=1. 🙇
There was a problem hiding this comment.
Yeah, that would make a good test case @ZehCnaS34
There was a problem hiding this comment.
@harold @WorldsEndless thanks! Instead of using an if expression to check if (= 1 a) I wanted to use 255 emplace of 256. But doing that would have affected the case where (= a 0.5)
Hopefully the if expression is alright.
| (-> (util/format "%2s" (util/int->string v 16)) | ||
| (string/replace " " "0")))] | ||
| (str (apply str "#" (map hex-part [r g b]) ) | ||
| (if (= 1 a) |
There was a problem hiding this comment.
This is an interesting approach; I'm always skeptical of using = to compare floating point numbers, but in this case I think it's okay due to how rgba works (specifically, how it ensures 0 <= a <= 1).
👍
In particular, (rgba->hex {:red 0 :green 0 :blue 0 :alpha 1.5}) produces a confusing answer, but perhaps that's okay.
Changing this line to (if (>= a 1) ... is one possible consideration.
Good work, by the way, love to see this library living/impoved.
|
@WorldsEndless @harold I don't have the time to review these PRs, however, I trust both of you to make good decisions. 😄 |
Related issue #182